Skip to content

Fix encoding of directoryName constraints#429

Merged
djc merged 1 commit into
rustls:mainfrom
sfackler:explicit-dn
May 10, 2026
Merged

Fix encoding of directoryName constraints#429
djc merged 1 commit into
rustls:mainfrom
sfackler:explicit-dn

Conversation

@sfackler
Copy link
Copy Markdown
Contributor

Without this fix, OpenSSL fails to parse the name constraint (see the tagged issue).

Closes #428

Copy link
Copy Markdown
Member

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Copy Markdown
Member

@cpu cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

Comment thread rcgen/src/certificate.rs
@djc djc added this pull request to the merge queue May 10, 2026
Merged via the queue into rustls:main with commit a32fdb1 May 10, 2026
16 of 17 checks passed
@djc djc mentioned this pull request May 10, 2026
eleboucher pushed a commit to eleboucher/towonel that referenced this pull request May 11, 2026
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [rcgen](https://github.com/rustls/rcgen) | workspace.dependencies | patch | `0.14.7` → `0.14.8` |

---

### Release Notes

<details>
<summary>rustls/rcgen (rcgen)</summary>

### [`v0.14.8`](https://github.com/rustls/rcgen/releases/tag/v0.14.8): 0.14.8

[Compare Source](rustls/rcgen@v0.14.7...v0.14.8)

#### What's Changed

- Fix incorrect identifier for ML-DSA signature algorithms by [@&#8203;DarkmatterVale](https://github.com/DarkmatterVale) in [#&#8203;412](rustls/rcgen#412)
- Upgrade yasna to 0.6 by [@&#8203;djc](https://github.com/djc) in [#&#8203;419](rustls/rcgen#419)
- Add support for is\_ca in CSR Params by [@&#8203;5Dev24](https://github.com/5Dev24) in [#&#8203;420](rustls/rcgen#420)
- Add support for serializing BasicConstraints in CSR's by [@&#8203;5Dev24](https://github.com/5Dev24) in [#&#8203;422](rustls/rcgen#422)
- update key\_pair to signing\_key in README.md by [@&#8203;fakelozic](https://github.com/fakelozic) in [#&#8203;427](rustls/rcgen#427)
- Fix encoding of directoryName constraints by [@&#8203;sfackler](https://github.com/sfackler) in [#&#8203;429](rustls/rcgen#429)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4xMDEuMSIsInVwZGF0ZWRJblZlciI6IjQzLjEwMS4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJ0eXBlL3BhdGNoIl19-->

Reviewed-on: https://git.erwanleboucher.dev/eleboucher/towonel/pulls/37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

rcgen incorrectly encodes directoryName constraints

3 participants